On Fri, 6 Jun 2025 12:00:37 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](https://bugs.openjdk.org/browse/JDK-8350588) >> >> This JEP proposes to enhance the HttpClient implementation to support HTTP/3. >> It adds a non-exposed / non-exported internal implementation of the QUIC >> protocol based on DatagramChannel and the SunJSSE SSLContext provider. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 499 commits: > > - merge latest changes from master branch > - http3: improve H3ConnectionPoolTest.java > - Fix snippet > - Improve key destruction > - merge latest changes from master branch > - http3: fix bug introduced by Http3ConnectionPool and improved debug logs > - http3: refactor HTTP/3 connection pool management in a separate class > - Ignore DestroyFailedExceptions > - Remove outdated TODO > - Remove outdated TODO > - ... and 489 more: https://git.openjdk.org/jdk/compare/65fda5c0...a5a0c7f8 src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java line 164: > 162: */ > 163: static AlgorithmConstraints forQUIC(QuicTLSEngine engine, > 164: boolean > applyCertPathAlgConstraints) { This parameter should be called `withDefaultCertPathConstraints` for consistency with other methods. src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java line 188: > 186: static AlgorithmConstraints forQUIC(QuicTLSEngine engine, > 187: String[] supportedAlgorithms, > 188: boolean > applyCertPathAlgConstraints) { Same as above: should be called `withDefaultCertPathConstraints` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2138853006 PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2138853942
