On Fri, 13 Jun 2025 14:37:51 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> New `XMLSignContext` property to allow user-specific `SecureRandom` for XML 
>> signature generation.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   rename

Also copyright

src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRSAPSSSignatureMethod.java
 line 33:

> 31: import java.security.Key;
> 32: import java.security.NoSuchAlgorithmException;
> 33: import java.security.PrivateKey;

Do we need a copyright update here and in `DOMSignatureMethod.java`?

test/jdk/javax/xml/crypto/dsig/Properties.java line 34:

> 32: import java.security.Security;
> 33: import java.util.Base64;
> 34: import java.util.logging.*;

Nitpick: this is not needed

-------------

PR Review: https://git.openjdk.org/jdk/pull/25802#pullrequestreview-2932584212
PR Review Comment: https://git.openjdk.org/jdk/pull/25802#discussion_r2150411773
PR Review Comment: https://git.openjdk.org/jdk/pull/25802#discussion_r2150284518

Reply via email to