On Tue, 24 Jun 2025 10:41:29 GMT, Mikhail Yankelevich 
<myankelev...@openjdk.org> wrote:

>> * added an automated mixed case option
>> * using multithreading now
>> * added logs for simpler debug
>> * added missing -Djava.security.auth.debug coverage
>
> Mikhail Yankelevich has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   comments & split test to 3

As the original contributor of this test case, it's nice to see the speed up 
via use of ExecutorService.

The upper case and lower case property tests are somewhat questionable IMO. One 
or two lines of test code would suffice but now we have a lot of noise 
distracting from the original intent of the test code. One could argue that 
every system property in the JDK could be subject to the same uppercase/lower 
case testing but such tests don't exist. A few lines of test code can easily 
verify behavior. Anything else enters the fuzzy logic testing approach. Hope 
it's not a pattern that new tests have to adopt.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25391#pullrequestreview-2953749743

Reply via email to