On Tue, 24 Jun 2025 11:44:44 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> SLSLogger is broken when used with with `System.Logger` (-Djavax.net.debug
>> mode)
>>
>> SSL Debug messages don't use format specifiers. As a result, any custom
>> format data isn't printed. Proposed solution is to append the SSL custom
>> format output to the original debug message. Similar approach used for
>> `SSLConsoleLogger ` mode.
>>
>> Used this opportunity to delete some old commented code and to replace use
>> of `"\n"` with `System.lineSeparator()`
>>
>> DebugPropertyValuesTest also updated to test new logic.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Text Blocks use \n by default
src/java.base/share/classes/sun/security/ssl/Utilities.java line 154:
> 152: StringBuilder builder = new StringBuilder();
> 153: if (source == null) {
> 154: builder.append(LINE_SEP).append(prefix).append("<blank
> message>");
I don't think this ls covered by the test. Could you please add an empty case
to cover this?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25934#discussion_r2167723782
