On Mon, 30 Jun 2025 15:12:00 GMT, Chen Liang <li...@openjdk.org> wrote:
>> src/java.base/share/classes/java/security/SecureRandom.java line 841: >> >>> 839: } >>> 840: >>> 841: @Override >> >> This method will appear in the javadoc for `SecureRandom` now, so I think >> you need to add the `inheritDoc` tag to incorporate the superclass` javadoc. > > This won't appear in the list of methods declared by `SecureRandom`. An > analogy is > [`ConcurrentHashMap::forEach(BiConsumer)`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/util/concurrent/ConcurrentHashMap.html#methods-inherited-from-class-java.util.concurrent.ConcurrentMap): > this method is [overridden in > `ConcurrentHashMap`](https://github.com/openjdk/jdk/blob/jdk24/src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java#L1613) > but is described by Javadoc as "Methods declared in interface > java.util.concurrent.ConcurrentMap". > > Since this method won't appear, we don't need an `@inheritDoc` tag. I don't know, that seems less obvious to me, as I can't tell if the class is overriding the method or not. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26005#discussion_r2175339692
