This PR is for clarifying the `NoSuchAlgorithmException` and 
`NoSuchPaddingException` for the `Cipher.getInstance(String transformation, 
Provider provider)` and `Cipher.getInstance(String transformation, String 
provider)` methods.

As stated in `javax.crypto.CipherSpi` class, provider has the flexibility to 
register their implementations through various sub-transformations. As a 
result, depending on how the providers register the implementation, it may lead 
to `NoSuchAlgorithmException` or `NoSuchPaddingException`. For example, the 
provider A registers to support "AES/CBC/PKCS5Padding" vs provider B registers 
to support "AES" (but would only accept "CBC" and "PKCS5Padding" as the valid 
input for setting mode and padding). Calling `Cipher.getInstance(...)` with 
"AES/CBC/NoPadding" against provider A and B would lead to 
`NoSuchAlgorithmException` and `NoSuchPaddingException`. This javadoc update 
hope to make it clear.

Thanks in advance for the review~
Valerie

-------------

Commit messages:
 - 8360463: Ambiguity in Cipher.getInstance() specification between 
NoSuchAlgorithmException and NoSuchPaddingException

Changes: https://git.openjdk.org/jdk/pull/26489/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26489&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8360463
  Stats: 14 lines in 1 file changed: 4 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/26489.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26489/head:pull/26489

PR: https://git.openjdk.org/jdk/pull/26489

Reply via email to