On Mon, 28 Jul 2025 19:08:56 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into 8347938
>> - KeyChoices class
>> - allow expanded to be null
>> - merge
>> - Merge
>> - safer privKeyToPubKey; updated desciptions for the properties; adding
>> braces to if blocks
>> - the fix
>
> test/jdk/sun/security/provider/named/NamedKeys.java line 47:
>
>> 45: // Create a key using raw bytes
>> 46: var sk = NamedPKCS8Key.internalCreate("SHA", "SHA-256", raw,
>> null);
>> 47: var enc = sk.getEncoded().clone();
>
> Why do you clone this?
This is useless. `getEncoded` should have already returned a new copy.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24969#discussion_r2238122212
