On Tue, 29 Jul 2025 14:55:04 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rename getRawClassAccessFlags to getClassFileAccessFlags and fix the test >> to reflect what the JVM does. > > src/java.base/share/classes/java/lang/Class.java line 248: > >> 246: protectionDomain = pd; >> 247: primitive = isPrim; >> 248: classFileAccessFlags = flags; > > Its not that hard to add a field, why not have done this for identity? Fields are initialized by injection in javaClasses instead of through this constructor, so it's easy for us to accidentally forget to inject a field. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26517#discussion_r2240207422
