On Tue, 29 Jul 2025 19:03:26 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 88: > >> 86: uidCounter = new AtomicLong(); >> 87: entryCacheMap = Collections.synchronizedMap >> 88: (new SizedMap<>()); > > You can remove `SizedMap` on lines 94-101. Did you see any reason why a > `LinkedHashMap` was used? (I cannot, but this code has not changed in many > releases, so we should be sure its ok). Looks like `LinkedHashMap` was used so we can remove the eldest entry, the `SizedMap` is limited to the size of 10. Actually, I'll restore the original assignment of `entryCacheMap` to preserve the original cache design. I should have paid more attention to this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25016#discussion_r2240765575
