On Wed, 30 Jul 2025 18:51:36 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments from Sean and Tony.
>
> test/jdk/java/security/KeyStore/TestDisabledAlgorithms.java line 41:
>
>> 39: import java.security.Provider;
>> 40: import java.security.Security;
>> 41: import java.security.cert.CertificateException;
>
> 4 of the above imports are not being used
Thanks, I will clean them up.
> test/jdk/java/security/KeyStore/TestDisabledAlgorithms.java line 118:
>
>> 116:
>> 117: boolean shouldThrow = Boolean.valueOf(args[1]);
>> 118: Security.getProperty(PROP_NAME).equalsIgnoreCase("false");
>
> Result of this statement is ignored.
Obsolete code and should be removed. Thanks!
> test/jdk/java/security/MessageDigest/TestDisabledAlgorithms.java line 75:
>
>> 73:
>> 74: boolean shouldThrow = Boolean.valueOf(args[1]);
>> 75: Security.getProperty(PROP_NAME).equalsIgnoreCase("false");
>
> Same as above, result of this statement is ignored.
Will remove.
> test/jdk/java/security/Signature/TestDisabledAlgorithms.java line 75:
>
>> 73:
>> 74: boolean shouldThrow = Boolean.valueOf(args[1]);
>> 75: Security.getProperty(PROP_NAME).equalsIgnoreCase("false");
>
> Same as above.
Will remove.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244439872
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244442141
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244443447
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244445231
