On Thu, 7 Aug 2025 17:43:53 GMT, Artur Barashev <abaras...@openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Address review comments from Artur and added a regression test for
>>   invalid property values.
>
> test/jdk/java/security/Security/SecurityPropFile/InvalidCryptoDisabledAlgos.java
>  line 52:
> 
>> 50:             MessageDigest md = MessageDigest.getInstance("SHA-512");
>> 51:             throw new RuntimeException("Should Fail!");
>> 52:         } catch (ExceptionInInitializerError e) {
> 
> Nit: Consider using `runAndCheckException` from `/test/lib`

Yes, good suggestion, thanks~

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2261311950

Reply via email to