On Tue, 19 Aug 2025 06:38:01 GMT, SendaoYan <s...@openjdk.org> wrote:
>> No change should be made to any explicit setting of the timeoutFactor in >> general as that could cause mass timeouts to occur (old default timeout = >> 120 * 10 = 1200 but new default = 120 * 2.5 = 300!). >> >> However I see the concern of @sendaoYan because individual tests may now get >> much larger timeout values when run with the non-default timeoutFactor >> because they have been adjusted for the new default. I don't see any >> solution to this dilemma. > > But what this PR do is change the timeoutFactor in general and find out all > the tests which may timeout after the timeoutFactor has been changed. > > The old default timeout before this PR is 120 * 4, after this PR the new > default is 120 * 1 I do not think 4x longer timeouts for `-Xcomp` is unreasonable. I also do not want to make this huge change even bigger. If you would like to change it after the integration I think that would be valuable --- though my guess is that it could be quite a lot of work. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2284650722
