On Wed, 23 Jul 2025 11:00:57 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - http3: fix new HttpHeadersBuilder constructor >> - qpack - optimize processing of decoder instruction exceptions >> - http3/quic: update the code to use the newly introduced >> jdk.internal.net.http.Origin >> - Avoid speculating about the future in TODOs >> - http3: rename PacketSpaceManager::isAcknowledging to >> PacketSpaceManager::trackAcknowledgement >> - merge latest changes from master branch >> - http3: fix typo in UniStreamPair.java >> - WriterQueue may leak before the constructor completes >> - Limit the number of retries in H3UserInfoTest >> - ... and 540 more: https://git.openjdk.org/jdk/compare/7b255b8a...f0a4fd3d > > test/jdk/java/net/httpclient/AsFileDownloadTest.java line 453: > >> 451: >> 452: @Override >> 453: public void handle(HttpTestExchange t) throws IOException { > > this is almost an exact copy of the method above. Right. Thanks for spotting that. The right thing to do here would be to refactor the HTTP/2 part of the test to stop using Http2TestServer but use HttpTestServer instead, like the new HTTP/3 part. That would get rid of the almost duplicate. I have logged https://bugs.openjdk.org/browse/JDK-8365802 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2285564303
