On Thu, 21 Aug 2025 12:27:19 GMT, Mikhail Yankelevich
<myankelev...@openjdk.org> wrote:
>> * cleanup
>> * changed tests hiding errors and skips to be different `@test`, so the
>> errors could be thrown
>> * tests affected:
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPoly.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCipherMode.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyNoReuse.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyKAT.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestGCMKeyAndIvCheck.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestKATForGCM.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipherWrap.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestChaChaPolyOutputSize.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphers.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestCICOWithGCM.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java
>> - /test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java
>> - /test/jdk/sun/security/pkcs11/Cipher/Test4512704.java
>
> Mikhail Yankelevich has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Update TestPKCS5PaddingError.java
> - cleanup and added id to tests
Looks good. Just a few minor tweaks.
test/jdk/sun/security/pkcs11/Cipher/ReinitCipher.java line 51:
> 49: public void main(Provider p) throws Exception {
> 50: if (p.getService("Cipher", "ARCFOUR") == null) {
> 51: throw new SkippedException("Not supported by provider,
> skipping");
minor nit: include the not-supported algorithm in the message.
test/jdk/sun/security/pkcs11/Cipher/TestRSACipher.java line 59:
> 57: Cipher.getInstance(RSA_ALGOS[0], p);
> 58: } catch (GeneralSecurityException e) {
> 59: throw new SkippedException("Not supported by provider,
> skipping");
minor nit: include the not-supported algorithm in the message.
test/jdk/sun/security/pkcs11/Cipher/TestRawRSACipher.java line 53:
> 51: Cipher.getInstance("RSA/ECB/NoPadding", p);
> 52: } catch (GeneralSecurityException e) {
> 53: throw new SkippedException("Not supported by provider,
> skipping");
minor nit: include the not-supported algorithm in the message.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26875#pullrequestreview-3140604472
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2291016041
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2291011826
PR Review Comment: https://git.openjdk.org/jdk/pull/26875#discussion_r2291012330
