On Fri, 22 Aug 2025 18:39:16 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> The existing error handling - to log and bail out - are 100% right. We're >> not throwing an exception so the caller still needs to unwind itself as well >> and a `return false;` after the >> `MetaspaceShared::unrecoverable_writing_error();` makes it more obvious how >> the caller should handle it - it too should bail as early as it can > > `MetaspaceShared::unrecoverable_writing_error()` will terminate the VM. So we > will never return to the caller.
That makes sense. Thanks for confirming. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26375#discussion_r2294480616
