On Mon, 25 Aug 2025 19:05:59 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8325448: Hybrid Public Key Encryption > > src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 102: > >> 100: * At HPKE cipher initialization, if no HPKE implementation supports >> the provided >> 101: * key type, an {@code InvalidKeyException} should be thrown. If the >> provided >> 102: * {@code HPKEParameterSpec} is not supported by any HPKE >> implementation, > > "is not supported" is typically used when an algorithm is not supported. I > think you need different wording like "invalid parameters". Maybe "is not accepted"? > src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 119: > >> 117: * of RFC 9180. >> 118: * <p> >> 119: * As with any AEAD cipher, each {@code doFinal} call on the server >> side must > > Hmm, I see a bit of a disconnect here since it starts talking about AEAD > cipher, but this is an HPKE cipher. Suggest you need a lead-in sentence with > what part/step of the HPKE you are referring to. > > Also, instead of "server" probably better to say "receiver". How about "HPKE internally uses an AEAD cipher for message encryption and decryption."? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2301362723 PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2301371328