On Wed, 27 Aug 2025 12:23:21 GMT, Sean Mullan <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address Sean's comments
>
> src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 125:
>
>> 123: * <p>
>> 124: * HPKE internally uses an AEAD cipher for message encryption and
>> decryption.
>> 125: * As with any AEAD cipher, each {@code doFinal} call on the receiver
>> side must
>
> Should say something like IV must be set each time, so the next sentence
> makes more sense where you talk about IVs.
I've combined this paragraph and the one before it into one. Since the first
paragraph already mentioned the use of AEAD, I dropped the "HPKE uses AEAD
internally" sentence.
See the new commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2304487506
