On Wed, 27 Aug 2025 16:06:14 GMT, Weijun Wang <[email protected]> wrote:
>> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> >> <img alt="spec" >> src="https://github.com/user-attachments/assets/12171f32-af07-4503-82c3-dd1c086b3863"; >> /> > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > more spec change src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 270: > 268: > 269: /** > 270: * Creates a new {@code HPKEParameterSpec} object with a different I kind of find the word "different" a little confusing here, since one might be calling this for the first time so it would not be different. Suggest just saying "with the specified ...". Same comment for other methods. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2305134000
