On Wed, 27 Aug 2025 23:48:28 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Providing a couple of utility methods using the "built-in" `Console`
>> implementation to support tools that require password input, such as
>> `keytool`, ensuring they work even when stdin is redirected.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> @Native annotated
test/jdk/java/io/Console/ModuleSelectionTest.java line 96:
> 94: var jdkc = Class.forName("jdk.internal.io.JdkConsole");
> 95: var lookup = MethodHandles.privateLookupIn(Console.class,
> MethodHandles.lookup());
> 96: var istty= (boolean)lookup.findStatic(Console.class,
> "isStdinTty", MethodType.methodType(boolean.class))
Suggestion:
var istty = (boolean)lookup.findStatic(Console.class, "isStdinTty",
MethodType.methodType(boolean.class))
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26973#discussion_r2306857436
