On Sat, 30 Aug 2025 01:16:01 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 35 commits: >> >> - Merge branch 'master' into 8044609-ssl >> - 1 file omitted during merge >> - Merge branch 'master' into 8044609-ssl >> - Merge branch 'master' into 8044609-ssl >> - Merge branch 'master' into 8044609-ssl >> - remove whitespace >> - erroneous edit to test file >> - remove legacy test and minor fix ups >> - Merge branch 'master' into 8044609-ssl >> - enums refactoring and line width correction >> - ... and 25 more: https://git.openjdk.org/jdk/compare/2b44ed70...71aa0211 > > src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 203: > >> 201: System.err.println("\thandshake print each handshake >> message"); >> 202: System.err.println("\tkeymanager print key manager tracing"); >> 203: System.err.println("\trecord enable per-record tracing"); > > What would you think of listing/indenting the suboptions here instead of down > below? e.g. > > record enable per-record tracing > plaintext hex dump of record plaintext (widens record) > packet print raw SSL/TLS packets (widens record) > > same with `verbose` Good idea. I've gone with that approach. > src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 223: > >> 221: } >> 222: >> 223: public enum Opt { > > A quick comment about the enum's purpose might be appreciated by someone new. > "list of options, whether they are active..." Added some text to indicate purpose of the new enum type ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r2314229266 PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r2314230004
