On Tue, 26 Aug 2025 17:30:54 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> Skipped tests are treated as a pass:
>>
>> * test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java
>> * test/jdk/sun/security/pkcs11/KeyStore/CertChainRemoval.java
>> * test/jdk/sun/security/pkcs11/SecretKeyFactory/TestGeneral.java
>> * test/jdk/sun/security/pkcs11/SecureRandom/Basic.java
>> * test/jdk/sun/security/pkcs11/SecureRandom/TestDeserialization.java
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8366159: SkippedException is treated as a pass for pkcs11/KeyStore,
> pkcs11/SecretKeyFactory and pkcs11/SecureRandom
test/jdk/sun/security/pkcs11/SecretKeyFactory/TestGeneral.java line 125:
> 123: test("Blowfish", bf_128Key, p, TestResult.PASS);
> 124: } catch (SkippedException skippedException){
> 125: throw new SkippedException("One or more tests skipped");
The original test runs all cases but the updated would stop once any of them is
skipped. Is this intended?
Also, I cannot see a benefit to rethrow a `SkippedException` with only a
modified message. Why not just let it bubble up?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26942#discussion_r2322324517
