On Tue, 2 Sep 2025 12:38:57 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> This PR extends security tests to use ByteBuffers backed by MemorySegments. >> Tests in the areas of Signature, Cipher, MessageDigest, and Mac are updated. > > Matthew Donovan has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - addressed PR comments and refactored to use try-with-resources > - Merge branch 'master' into cipher-ffm > - 8357466: Create test for Ciphers that are using ByteBuffers backed by > MemorySegments > There is a recent bug fix at #27081 when a slice of an array-based buffer is > used. Can you investigate why it has not been caught by this test? Should it > be enhanced? Thanks. There are a lot of tests under `test/jdk/com/sun/crypto/provider` that I didn't look at. There are some that explicitly test ByteBuffers (such as `Cipher/AEAD/OverlapByteBuffer.java`) and others that could possibly be extended to include them. I think updating all the tests would be unnecessary but I can update the tests that explicitly use ByteBuffer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26967#issuecomment-3258867557
