On Tue, 9 Sep 2025 15:27:20 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix comments
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 137:
> 
>> 135:     }
>> 136: 
>> 137:     // Dedicated entry for sun.security.util.Password.
> 
> To be more clear, I suggest this comment:
> 
>     // Dedicated entry for sun.security.util.Password when stdout is 
> redirected.
>     // This method strictly avoids producing any output by using noNewLine = 
> true
>     // and an empty format string.

Thanks. Modified the comment as suggested

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26973#discussion_r2334255209

Reply via email to