On Fri, 12 Sep 2025 19:30:21 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 58 commits: >> >> - Merge branch 'master' into 8325448 >> - about transformation >> - cannot reset with withMethods >> - algorithm identifier >> - withMethods >> - duplicated "value" words >> - receiver to recipient; different to specified >> - use different exception type >> - more spec change >> - address Sean's comments >> - ... and 48 more: https://git.openjdk.org/jdk/compare/7fcce270...1ec31cf5 > > src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line 286: > >> 284: * @throws IllegalArgumentException if {@code info} is empty. >> 285: */ >> 286: public HPKEParameterSpec withInfo(byte[] info) { > > After reading your example at the class javadoc level, it left me with the > impression that `withInfo()` would be used with `String`. Does it make sense > to have a `withInfo(String)` method? Or maybe the example less > String-specific? Oh, I just want to be self-contained in the example and `new byte[10]` seems too trivial. Actually, it's very likely not a string. For example, in TLS Encrypted Client Hello, it's `"tls ech" || 0x00 || ECHConfig`. I don't think it's worth adding an overloaded `withInfo(String)`. It's similar to the `info` in HKDF-Expand. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2345601851
