On Wed, 3 Sep 2025 19:35:27 GMT, Matthew Donovan <[email protected]> wrote:
>> In this PR I added TLS groups and signature algorithms to the output of the
>> show settings flag. The values are printed in a single column, like the
>> cipher suites. There can be a lot of values so putting on a single line is
>> ugly. I tried putting them in columns, but it is hard to read.
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - I removed signature algorithms output because the information is created
> during TLS handshake
> - Merge branch 'master' into secsettings
> - removed unused import, updated tools/launcher/Settings.java test
> - Merge branch 'master' into secsettings
> - 8351354: Enhance java -XshowSettings:security:tls to show enabled TLS
> groups and signature algorithms
src/java.base/share/classes/sun/launcher/SecuritySettings.java line 140:
> 138: }
> 139:
> 140: ostream.println("\n" + TWOINDENT + "Enabled Groups:");
Change this to "Enabled Named Groups:". This would be more consistent with the
API (`get/setNamedGroups`) and the Named Groups section of the Standard
Algorithm Names spec.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24424#discussion_r2414604767
