On Mon, 13 Oct 2025 13:22:31 GMT, Daniel Jeliński <[email protected]> wrote:

>> Artur Barashev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   The fix and unit test for session resumption case
>
> test/jdk/javax/net/ssl/DTLS/DTLSOverDatagram.java line 541:
> 
>> 539:                 new InetSocketAddress(HOST, SERVER_PORT);
>> 540:         InetSocketAddress clientSocketAddress =
>> 541:                 new InetSocketAddress(HOST, CLIENT_PORT);
> 
> Don't fix ports here. There's a nonzero chance that some other process will 
> take these ports before you.
> 
> Use port zero here. The port numbers used in SSLEngine don't need to match 
> the datagram socket, they just need to match between the initial session and 
> the resumption.

Good catch, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27677#discussion_r2426435630

Reply via email to