On Fri, 26 Sep 2025 21:47:19 GMT, Anthony Scarpino <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Francesco's comment >> >> Co-authored-by: Francesco Andreuzzi <[email protected]> > > test/jdk/javax/net/ssl/interop/ClientHelloBufferUnderflowException.java line > 33: > >> 31: * @bug 8215790 8219389 >> 32: * @summary Verify exception >> 33: * @enablePreview > > There doesn't look to be any PEM usage in this test This class extends `ClientHelloInterOp`, so needs an updated tag. > test/jdk/javax/net/ssl/interop/ClientHelloChromeInterOp.java line 33: > >> 31: * @bug 8169362 >> 32: * @summary Interop automated testing with Chrome >> 33: * @enablePreview > > Appears not to need PEM This class extends `ClientHelloInterOp`, so needs an updated tag. > test/jdk/javax/net/ssl/interop/ClientHelloInterOp.java line 296: > >> 294: >> 295: // generate the private key. >> 296: String keyMaterialStrPEMFormat = new PEMRecord("PRIVATE >> KEY", keyMaterialKeys[i]).toString(); > > Should this one be done with > [JDK-8367326](https://bugs.openjdk.org/browse/JDK-8367326) instead of this PR? Yes, you're right, I must have missed this one when removing `PEMRecord` classes from this PR. I'll change it to not use PEMRecord or move it to JDK-8367326 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27194#discussion_r2387342488 PR Review Comment: https://git.openjdk.org/jdk/pull/27194#discussion_r2387342957 PR Review Comment: https://git.openjdk.org/jdk/pull/27194#discussion_r2387348814
