On Mon, 29 Sep 2025 21:07:12 GMT, Weijun Wang <[email protected]> wrote:
>> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> another day another iteration > > src/java.base/share/classes/com/sun/crypto/provider/PBMAC1Parameters.java > line 69: > >> 67: private String pbmac1AlgorithmName = null; >> 68: >> 69: private byte[] salt = null; > > Instead of including so many PBKDF2 components, can we just put one > `PBKDF2Parameters` field here? We can also remove the `getPrf`, `getSalt`, > and `getIterations` methods. IMO it's not awkward to call > `pbmac1Params.getKdfParams().getPrf()` etc. fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2406977451
