On Wed, 22 Oct 2025 12:42:56 GMT, Sean Mullan <[email protected]> wrote:

>> @wangweij is correct, `generateEncoding()` is setting the instance variable 
>> `encodedKey`.    A finally-block is likely necessary if an exception happens 
>> after `privateKeyMaterial` is set in `generateEncoding()`
>
> Ok, that could be fixed by creating another method that just does the 
> encoding (and change `generateEncoding` to call that), but maybe we can fix 
> that later.

There are generic changes to PKCS8Key outside of PEM that I'd like to do, I can 
look at it then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27147#discussion_r2452669136

Reply via email to