On Mon, 27 Oct 2025 13:21:47 GMT, Weijun Wang <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more docs, remove runtimeexception
>
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line
> 434:
>
>> 432: * {@code null}, the provider’s default parameters
>> are applied.
>> 433: * @param random the {@code SecureRandom} instance used during
>> encryption.
>> 434: * If {@code null}, the default is used
>
> This method does not include an `@implNote` talking about what "the default"
> `SecureRandom` means. Shall we just say here that the provider would choose
> one?
I don't feel we need to be precise here. Very little is mentioned in methods
that don't take `SecureRandom`, but use it internally. If there was some
`@implNote`, it should be in the `SecureRandom` javadoc so every API didn't
have to explain it's usage.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27147#discussion_r2466746422
