On Fri, 7 Nov 2025 18:52:38 GMT, Mark Powers <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> a rename, a comment, and a new test case > > src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 540: > >> 538: * This verifies a given SignerInfo. >> 539: * >> 540: * @param info the signer information. > > I don't believe the period is necessary. Correct. There are too many such issues in this file, and I'd rather not touch any of them. After all, this is not a public API. > src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 544: > >> 542: * @param cert certificate used to verify; find one inside the >> block if null >> 543: * >> 544: * @exception NoSuchAlgorithmException on unrecognized algorithms. > > Shouldn't this be `@throws`? `@exception` is the old tag name. Same as above. > test/jdk/sun/security/tools/jarsigner/ML_DSA.java line 70: > >> 68: prepare(); >> 69: testAPI(); >> 70: testTool(); // call this last, it modified a.jar. > > s/modified/modifies/ Will fix. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2505753853 PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2505754119 PR Review Comment: https://git.openjdk.org/jdk/pull/26563#discussion_r2505754644
