On Thu, 13 Nov 2025 06:43:36 GMT, Alan Bateman <[email protected]> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Remove path resolution from exception message
>
> src/java.base/share/classes/java/security/Security.java line 275:
>
>> 273: // specified to exist even for nonexistent/inaccessible
>> files.
>> 274: try {
>> 275: return path.toFile().getCanonicalFile().toPath();
>
> @seanjmullan If this change is integrated, can we create a follow-up on issue
> to replace it? I strongly disagree with the changes in this PR, we should not
> be using File::getCanonicalFile here to work around an issue with an
> inaccessible parent directory.
Just wanted to note that I also dislike this change, but is the only way I
found to support relative includes in Windows UWP Java applications.
I'm open to other suggestions, including going back to `Path::toRealPath` and
dropping that use-case (while still fixing the original
[JDK-8352728](https://bugs.openjdk.org/browse/JDK-8352728 "InternalError
loading java.security due to Windows parent folder permissions") issue), even
though that isn't my preference.
@AlanBateman: do you disagree with other changes in this PR? I'm not
comfortable integrating something that we haven't agreed upon.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24465#discussion_r2523745568
