On Fri, 14 Nov 2025 17:21:50 GMT, Martin Doerr <[email protected]> wrote:

>> This fix simplifies the hotspot intrinsics for some platforms and optimizes 
>> the key computation for encryption. We can save the `genInvRoundKeys` 
>> computation when we only do encryption.
>> 
>> The micro:org.openjdk.bench.javax.crypto.AESReinit benchmark results are 
>> improved by 17% for ppc64 and 26% for x86_64.
>
> Martin Doerr has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   More minor cleanup.

@valeriep, @jnimeh: I've seen that you have reviewed other changes in this area 
and I need reviews from Security Group people. I will certainly find reviewers 
for the hotspot part. May I ask you to take a look at the Java part?
I would slightly prefer doing a bit more changes, but wanted to check with you, 
first: 
https://github.com/TheRealMDoerr/jdk/commit/2907475958806cad6b5fc83541f66065475a93ec

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28299#issuecomment-3548795174

Reply via email to