On Tue, 18 Nov 2025 08:57:02 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix Whitespace error.
>
> test/jdk/com/sun/crypto/provider/Cipher/AES/TestAesGcmIntrinsic.java line 41:
>
>> 39: public class TestAesGcmIntrinsic {
>> 40:
>> 41: static final SecureRandom SECURE_RANDOM = newDefaultSecureRandom();
>
> Do you really need a `SecureRandom` here? `Random RANDOM =
> Utils.getRandomInstance();` gets you the pre-seeded random instance, which
> can be used to repeatably reproduce failures.
I kept the `SecureRandom` without changing. I think that could be more related
to what the original reproducible.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28363#discussion_r2544361801
