On Mon, 24 Nov 2025 17:00:04 GMT, Martin Doerr <[email protected]> wrote:

>> This fix simplifies the hotspot intrinsics for some platforms and optimizes 
>> the key computation for encryption. We can save the `genInvRoundKeys` 
>> computation when we only do encryption.
>> 
>> The micro:org.openjdk.bench.javax.crypto.AESReinit benchmark results are 
>> improved by 17% for ppc64 and 26% for x86_64.
>
> Martin Doerr has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains six additional 
> commits since the last revision:
> 
>  - Address review comments.
>  - Merge remote-tracking branch 'origin' into 8371820_AES_Crypt
>  - Remove K from AES_Crypt
>  - More minor cleanup.
>  - Improve comment and minor cleanup.
>  - 8371820: Further AES performance improvements for key schedule generation

src/hotspot/share/opto/library_call.cpp line 7236:

> 7234:   address stubAddr = nullptr;
> 7235:   const char *stubName = nullptr;
> 7236:   bool is_decrypt= false;

nit: s/is_decrypt= false/is_decrypt = false/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28299#discussion_r2558797828

Reply via email to