On Fri, 17 Oct 2025 10:07:37 GMT, Alan Bateman <[email protected]> wrote:
>>> @AlanBateman are you ok with letting the original >>> [c6f1d5f](https://github.com/openjdk/jdk/commit/c6f1d5f374bfa9bde75765391d5dae0e8e28b4ab) >>> reviewers know of this fix and take a look? Or do you think further >>> discussion is needed somewhere else? >> >> Have you had time to try using the file key to detect the recursive include >> case? > >> Hi @AlanBateman, I'm resuming the work on this one. >> >> > Have you had time to try using the file key to detect the recursive >> > include case? >> >> By "file key", do you mean `Files.readAttributes(Path.of("..."), >> BasicFileAttributes.class).fileKey()`? This works on _Linux_ but returns >> `null` on _Windows_. > > Can you try Files.isSameFile? It will use the file key on all platforms. If > the file located by the included path, and the previous files encountered, > are accessible then it can be loadFromPath.. > Yes, I agree that seems like a way forward, if not perfect. @AlanBateman ok > with you? Yes, this is okay with me. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24465#issuecomment-3585470952
