On Mon, 1 Dec 2025 18:24:07 GMT, Maurizio Cimadamore <[email protected]> wrote:
> Thanks for working on this problem. > > At the high level I understand your goal here. It is a bit unfortunate that > we have to change the API for acquire/release which cascades in many smaller > (but simple) changes throughout the JDK. But let's set that aside. Yes, that was regrettable. Originally I retained the "void release0()" that recalculated the "ticket", which resulted in fewer changes. However, it was felt the explicit ticket passing was less likely to introduce errors. > > The main (and more serious) issue with this PR is the decoupling of the > liveness bit from the ref counting part. This is something that will require > some time to work through to ensure correctness is preserved in all cases. > Yes, I had been grappling with the atomicity. The "acquireCount" and "state" are decoupled in the most recent revision of the, so this closing should either fail and not update state, or pass and complete the shutdown. However, the "state" and ScopedAccesses are complex, so I appreciate the scrutiny in that area. > More generally, it is generally advisable for such deep changes to perhaps > reach out to panama-dev mailing list first, and maybe have a discussion/reach > some consensus there, before moving ahead with a PR. That was my mistake - I expected that with the foreign ABI being merged, discussions on internals would have reverted to here. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28575#issuecomment-3598403208
