On Tue, 2 Dec 2025 13:26:54 GMT, Sean Mullan <[email protected]> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> two additional commits since the last revision:
>>
>> - Address review comments
>> - Slightly improve ConfigFileTestDirPermissions
>>
>> Extract restrictedAcl() AutoCloseable and also use AutoCloseable for the
>> temporary directory cleanup.
>
> test/jdk/java/security/Security/ConfigFileTestDirPermissions.java line 70:
>
>> 68: try {
>> 69: jdk.toRealPath();
>> 70: throw new jtreg.SkippedException("Must run
>> non-elevated!");
>
> Do you expect this to be a non-common situation? Just wondering if we should
> treat this as a failure instead of skipping.
It depends on how the test is run, is not really a failure, just that the test
would pass without actually testing the issue. But I have no problem with
considering it a failure anyway.
In my particular case, if I connect through SSH to my Windows VM, I end up
elevated, so I need to execute this test from the VM's GUI (my VM setup is a
bit unusual: I use _Windows_' native _OpenSSH_ service with _Cygwin_'s
`bash.exe` as the shell, and there is a single administrative user in the
system).
Originally I thought that making it a failure could break the test inside lots
of CI / test-execution environments, but perhaps is not the case. Can you
confirm it isn't being skipped on _Oracle_'s runs?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24465#discussion_r2581882104
