On Tue, 2 Dec 2025 19:36:49 GMT, Volkan Yazici <[email protected]> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   use Runnable() instead of CallableOp
>
> src/java.base/share/classes/java/util/jar/JarFile.java line 1047:
> 
>> 1045:                 jvInitialized = true;
>> 1046:             }
>> 1047:         });
> 
> You can consider shortening this using a lambda:
> 
> 
> ScopedValue.where(IN_VERIFIER_INIT, true).run(() -> {
>     initializeVerifier();
>     jvInitialized = true;
> });

Yes, but I think would be prudent to run startup benchmarks if you change that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28609#discussion_r2582636023

Reply via email to