On Tue, 2 Dec 2025 10:47:29 GMT, Arno Zeller <[email protected]> wrote:

>> - Stop catching exception to make test able to fail
>> - Remove java-only test variation that cannot fail
>> - Reduce fuzz repeat count
>
> The change looks good, but you might consider using 
> jdk.test.lib.RandomFactory. It allows to get and set a seed that is also 
> printed at every run to make a failure easily reproducible.
> 
> And as the test now fails on aarch64 perhaps it should be excluded there and 
> a bug should be opened - or is the behavior expected on aarch64 ?

> The integration of this change is unacceptable. The known aarch64 issue 
> should have been resolved before integration, not deferred to another bug. If 
> reviewers (@ArnoZeller @TheRealMDoerr) cannot verify other architectures, 
> then the PR should not be approved unless the submitter is explicitly 
> required to validate on all relevant platforms first.

Sorry for the to early approval and the issues caused by that! 
There is a PR to disable the test on non X86: #28650

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28584#issuecomment-3611197708

Reply via email to