On Fri, 19 Dec 2025 17:50:11 GMT, Sean Mullan <[email protected]> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> four additional commits since the last revision: >> >> - 3/3) Adjust ConfigFileTest for unresolved paths >> - 2/3) Refactor ConfigFileTest ExtraMode enum >> >> Move ExtraMode as an ExtraPropsFile field, so we have this information >> as soon as the ExtraPropsFile is created. This will be useful for the >> next change. >> - 1/3) Revert ConfigFileTest adjustment >> >> This reverts commit 7c80874c25bc99783ad24fb22d2c080d33c5503a only for >> ConfigFileTest. >> - Do not resolve symlinks for relative includes >> >> As @wangweij pointed out: >> > The person writing the original properties file may have expected >> > includes to resolve relative to its own location, but whoever created >> > the symlink may have intended a different resolution path. If they >> > wanted the original location, they could have just used the real file >> > directly instead of introducing a symlink. >> >> Since path resolution is causing trouble under certain conditions, let's >> avoid doing it. Other programs with include directives support in their >> configuration files are doing the same. > > Can you move the tests to `test/jdk/java/security/Security/SecurityPropFile`? > That seems like a better place for them. > @seanjmullan: also, if they are in the `SecurityPropFile` directory, I would > like to take advantage to rename them as follows: > > * `ConfigFileTest.java` → `ExtraFileAndIncludes.java` > > * `ConfigFileTestAnonymousPipes.java` → `LinuxAnonymousFiles.java` > > * `ConfigFileTestDirPermissions.java` → `WindowsParentDirPermissions.java` > > > Would you agree? Yes, the new names are better. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24465#issuecomment-3676611075
