On Mon, 22 Dec 2025 07:19:29 GMT, Shawn M Emery <[email protected]> wrote:
>> Rewrite the native calls with FFM.
>
> src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixSystem.java
> line 93:
>
>> 91: } catch (Throwable t) {
>> 92: var error = new UnsatisfiedLinkError("FFM calls failed");
>> 93: error.initCause(t);
>
> Do you want to check with getCause() here as well?
`getCause` of `t`? I'll just pass the whole `t` back to the caller.
> src/jdk.security.auth/share/classes/jdk/internal/ffi/generated/jaas_unix/package-info.java
> line 35:
>
>> 33: * echo "#include <spwd.h>" >> $HEADER_NAME
>> 34: *
>> 35: *
>
> nit: extra line, but please ignore if jextract generated.
Not generated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28931#discussion_r2640064230
PR Review Comment: https://git.openjdk.org/jdk/pull/28931#discussion_r2640065164
