On Fri, 2 Jan 2026 14:23:58 GMT, Martin Doerr <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rewrite without jextract
>
> src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixSystem.java
> line 96:
>
>> 94: .downcallHandle(SYMBOL_LOOKUP.findOrThrow("getpwuid_r"),
>> 95: FunctionDescriptor.of(C_INT, C_INT, C_POINTER,
>> C_POINTER,
>> 96: C_LONG, C_POINTER));
>
> `C_LONG` looks wrong for 32 bit platforms (arm 32). Note that `size_t` is
> supported by `canonicalLayouts`.
Do you see 64 bit?
<img width="588" height="306" alt="Screenshot 2026-01-02 at 10 26 20"
src="https://github.com/user-attachments/assets/82106d61-27f8-4871-a890-039971665e62";
/>
There is no arm32 here so I assume it will be the `FallbackLinker`. The size
will be returned by a JNI function `ffi_sizeof_long()`. No idea how it could go
wrong.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28931#discussion_r2657919123
