On Wed, 7 Jan 2026 06:18:55 GMT, Shawn M Emery <[email protected]> wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 862:
>>
>>> 860: __ addptr(condensed, condensedOffs);
>>> 861:
>>> 862: if (VM_Version::supports_avx512_vbmi2()) {
>>
>> Which instruction needs vbmi2? All I could spot was that `evpermb` that
>> needs vbmi. Relax the restriction slightly?
>
> Good catch! Initially the code was using `vpshldvw`, but was changed to just
> use `vpsrlvw`. Fixed in next commit.
> I should probably update the bug synopsis to exclude VBMI2?
I would be happy with just the code being pedantic. Everything else is 'just
nice' :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28815#discussion_r2669186665
