On Tue, 13 Jan 2026 18:08:50 GMT, Mikhail Yankelevich 
<[email protected]> wrote:

>> It will have a default `null` value. It's being assigned to the negotiated 
>> protocol outside of this file.
>
> Won't it require additional null checks then? Now it essentially defaults to 
> a max protocol version, which was always present (`ProtocolVersion.NONE` by 
> default)

We don't need null checks, `protocolVersion` currently is not used before it's 
set to the negotiated protocol, and we'll get a NPE if somebody tries to use it 
before it's set. It is basically a representation of negotiated protocol in 
`TransportContext`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29192#discussion_r2688081660

Reply via email to