On Wed, 14 Jan 2026 20:35:46 GMT, Weijun Wang <[email protected]> wrote:

>> I believe so, otherwise we will be either getting `Date` as before via 
>> `engineGetCreationDate` or have a default implementation from `KeyStoreSpi` 
>> which converts the result of `engineGetCreationDate`. This seems to me just 
>> an extra operation, which I'm not convinced is necessary. 
>> However, if you think in this case it might be ok - I'm happy to remove this 
>> and simplify.
>
> I would rewrite this `engineGetCreationDate` to call 
> `engineGetCreationInstant` and convert it. After all this code change is 
> about migrating from calling `getCreationDate` and it's called here.

Ok, should be done in the next commit. Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2693888840

Reply via email to