On Fri, 16 Jan 2026 00:46:48 GMT, Roger Calnan <[email protected]> wrote:

> adjust each of the command line options to include an html anchor so that one 
> can give a link that goes directly to the section in the man page that covers 
> a specific option

Looks good. Some might not be necessary.

src/java.base/share/man/keytool.md line 1591:

> 1589: The command creates the keystore named `mykeystore` in the working 
> directory
> 1590: (provided it doesn't already exist), and assigns it the password 
> specified by
> 1591: [`-keypass`]{#-keypass}. It generates a public/private key pair for the 
> entity whose

I'd rather not giving this an anchor. It just happens to be mentioned here. 
It's not the formal spec for it.

src/java.base/share/man/keytool.md line 2366:

> 2364: that don't conform to the standard might be rejected by the JDK or other
> 2365: applications. Users should ensure that they provide the correct options 
> for
> 2366: [`-dname`]{#-dname}, `-ext`, and so on.

Same for this one. No need to add an anchor here.

src/jdk.jartool/share/man/jarsigner.md line 800:

> 798:     path-separator character.
> 799: 
> 800: [`-J`]{#-J}*javaoption*

Maybe this one is not necessary. It's a general option for extra VM options.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29258#pullrequestreview-3672060086
PR Review Comment: https://git.openjdk.org/jdk/pull/29258#discussion_r2699459977
PR Review Comment: https://git.openjdk.org/jdk/pull/29258#discussion_r2699461011
PR Review Comment: https://git.openjdk.org/jdk/pull/29258#discussion_r2699471280

Reply via email to