On Thu, 22 Jan 2026 11:46:35 GMT, Weijun Wang <[email protected]> wrote:
>> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally >> with one additional commit since the last revision: >> >> 8345954: Addressing review comments > > src/java.base/share/classes/sun/security/provider/X509Factory.java line 183: > >> 181: X509CertImpl newC = isImpl ? (X509CertImpl) c : new >> X509CertImpl(encoding); >> 182: byte[] enc = isImpl ? encoding : newC.getEncodedInternal(); >> 183: return addToCache(certCache, enc, newC); > > Is this better than the old code? `isImpl` was only checked once. Makes sense. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29181#discussion_r2719068938
