On Tue, 3 Feb 2026 22:17:04 GMT, Valerie Peng <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test changes
>
> test/jdk/sun/security/pkcs11/Cipher/TestPKCS5PaddingError.java line 74:
>
>> 72:
>> 73: // Checking for SunJCE first
>> 74: System.out.println("Checking SunJCE provider");
>
> nit: how about printing out the value of `sunJCEProvider` instead of "SunJCE"?
Done in the next commit
> test/jdk/sun/security/pkcs11/Cipher/TestPKCS5PaddingError.java line 92:
>
>> 90: SecretKey key = kg.generateKey();
>> 91: Cipher c1 =
>> Cipher.getInstance(currTest.transformation,
>> 92: System.getProperty("test.provider.name",
>> "SunJCE"));
>
> nit: this can just be `sunJCEProvider`. No need for another
> System.getProperty(...) call?
Done in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29503#discussion_r2761254823
PR Review Comment: https://git.openjdk.org/jdk/pull/29503#discussion_r2761255209
