On Thu, 5 Feb 2026 20:32:36 GMT, Bradford Wetmore <[email protected]> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Further review comments from Brad
>
> src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java line 36:
>
>> 34: import javax.net.ssl.SSLProtocolException;
>> 35: import sun.security.ssl.SSLCipher.SSLReadCipher;
>> 36: import static sun.security.ssl.SSLLogger.Opt.*;
>
> Ugh...have to say I preferred the old style:
>
> `SSLLogger.isOn(SSLLogger.Opt.____)`
>
> Nothing technically wrong, just a personal preference, but the old way made
> it quick/easy to search for the various `Opt.*` values.
>
> `grep SSL *` would get you many unrelated, vs `grep SSLLogger.Opt.SSL *`.
sure - I'll revert to the other style. This one meant many lines didn't span 80
chars but I've adjusted for that now.
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 238:
>
>> 236: " all non-widening filters are enabled.%n");
>> 237: System.err.printf("%nSpecifying filter options with \"ssl\"" +
>> 238: " includes messages for the selected categories, as
>> well" +
>
> Maybe:
>
> `Specifying "ssl" with additional filter options produces the general SSL
> debug messages plus just the selected categories.`
>
> Also, maybe add a`\n` after "selected"? It's very long on a 80 char screen.
ok - I currently have the below. Hope that works.
Specifying "ssl" with additional filter options produces general
SSL debug messages plus just the selected categories.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r2775945736
PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r2775947081
